• Welcome to TalkativeTurtles - a community for developers & tech enthusiasts.
  • Share projects, get code reviewed, and talk tech without the noise.
  • New here? Introduce yourself in the Introductions forum!
Hello There, Guest! Login Register


Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Title: [Guide] What to look for when doing code review
Linear Mode
#1
Code review quality varies enormously. A rubber-stamp "LGTM" on every PR is useless; nitpicking whitespace for three rounds is demoralising. Here's what actually matters.

Things worth flagging:

Correctness - will this actually work? Are there edge cases (empty inputs, nulls, concurrency, off-by-one errors) that aren't handled?

Security - is user input validated and sanitised? Are there SQL injection, XSS, or path traversal risks? Are secrets handled correctly (not logged, not in responses)?

Logic errors in error handling - does the code handle failure gracefully? Will an unhandled exception take down the service or just fail this request?

Naming and clarity - if you have to read a function twice to understand what it does, the name or structure needs work. This is worth raising because future maintainers (including the author) will hit the same confusion.

Missing tests - if this adds new behaviour, are there tests? If it fixes a bug, is there a regression test?

Things not worth bikeshedding:
  • Formatting, if there's a linter enforcing it
  • Minor style preferences that don't affect readability
  • "I would have done it differently" without a concrete reason

How to give useful feedback:
  • Be specific - "this could be clearer" is less useful than "the variable name d doesn't tell me what this stores"
  • Explain why, not just what
  • Distinguish blockers from suggestions - prefix with Blocker: / Suggestion: / Nit:
  • Praise good work - it's not all criticism

Timebox it - a focused 30-minute review is more valuable than two hours of exhaustive comments that overwhelm the author.
Reply
  


Messages In This Thread
[Guide] What to look for when doing code review - by Zero Two - 06-22-2026, 12:36 PM

Possibly Related Threads…
Thread Author Replies Views Last Post
  Refactoring legacy code without breaking things - a practical approach Zero Two 0 158 06-22-2026, 12:45 PM
Last Post: Zero Two
  [Template] Code Review Submission Format Zero Two 0 280 06-21-2026, 09:42 AM
Last Post: Zero Two
  [Rules] Code Review & Feedback — Forum Rules Zero Two 0 165 06-21-2026, 09:34 AM
Last Post: Zero Two

Forum Jump:


Browsing: 1 Guest(s)